[Mlir-commits] [mlir] [MLIR] Make SymbolTableCollection methods virtual (PR #141760)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Wed May 28 06:30:50 PDT 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Michele Scuttari (mscuttari)

<details>
<summary>Changes</summary>

The `LockedSymbolTable` class not only encapsulate a `SymbolTableCollection`, but also extends it. However, the methods of `SymbolTableCollection` are not marked as `virtual`, and therefore methods receiving a `SymbolTableCollection` would always call the base methods even if the object was a subclass. The proposed changes consist in marking the base methods as `virtual`.

---
Full diff: https://github.com/llvm/llvm-project/pull/141760.diff


1 Files Affected:

- (modified) mlir/include/mlir/IR/SymbolTable.h (+21-12) 


``````````diff

``````````

</details>


https://github.com/llvm/llvm-project/pull/141760


More information about the Mlir-commits mailing list