[Mlir-commits] [mlir] [MLIR] Determine contiguousness of memrefs with a dynamic dimension (PR #140872)

[Momchil Velikov]

momchil-velikov wrote:

> I found the test of transfer_read
> 
> ```
> memref<1x4x?x6xi32> -> vector<1x2x6xi32> 
> ```
> 
> slightly confusing though, because the transfer_read itself is still contiguous because of the leading 1 in the vector shape (?)

Good point!
I think I need to fix a bit the logic in ` vector::isContiguousSlice`  where we  first want all the `N` trailing dimensions of the memref to be contiguous (where `N` is the vector rank), but then allow leading `1`s in the vector.
Perhaps if we have a `vector<1 x 1 x ... x 1 x d0 x d1 x ... x dn x T>` then we need to care for only the last `n+1` dimensions of the memref (I haven't yet thought that through, though).

https://github.com/llvm/llvm-project/pull/140872