[Mlir-commits] [mlir] [mlir][linalg] Fix EraseIdentityLinalgOp on fill-like ops (PR #130000)
Andrzej WarzyĆski
llvmlistbot at llvm.org
Wed May 28 02:04:07 PDT 2025
================
@@ -1285,13 +1285,17 @@ struct EraseIdentityLinalgOp : public OpRewritePattern<OpTy> {
// In the buffer case, we need to check exact buffer equality.
if (linalgOp.hasPureBufferSemantics()) {
- if (linalgOp.getNumDpsInputs() == 1 && linalgOp.getNumDpsInits() == 1 &&
- linalgOp.getDpsInputOperand(0)->get() ==
- linalgOp.getDpsInitOperand(0)->get()) {
- rewriter.eraseOp(linalgOp);
- return success();
- }
- return failure();
+ if (linalgOp.getNumDpsInputs() != 1 || linalgOp.getNumDpsInits() != 1 ||
+ linalgOp.getDpsInputOperand(0)->get() !=
+ linalgOp.getDpsInitOperand(0)->get())
+ return failure();
----------------
banach-space wrote:
Could these `failure`s be `notifyMatchFailure` instead?
https://github.com/llvm/llvm-project/pull/130000
More information about the Mlir-commits
mailing list