https://github.com/IanWood1 commented: This looks good to me as my comments have been addressed. I'm going to wait for Mahesh to review since he mentioned he wanted to review this https://github.com/llvm/llvm-project/pull/137963