[Mlir-commits] [mlir] [MLIR] Document the need for updating the cached symbol tables during bufferization (PR #141594)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-bufferization

Author: Michele Scuttari (mscuttari)

<details>
<summary>Changes</summary>



---
Full diff: https://github.com/llvm/llvm-project/pull/141594.diff


1 Files Affected:

- (modified) mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.td (+5) 


``````````diff
diff --git a/mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.td b/mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.td
index b599a9f053215..72974a8c808fd 100644
--- a/mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.td
+++ b/mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.td
@@ -416,6 +416,11 @@ def BufferizableOpInterface : OpInterface<"BufferizableOpInterface"> {
           expected to survive bufferization, `success` should be returned
           (together with `allow-unknown-ops` enabled).
 
+          If the bufferized operation has symbol semantics (i.e., it defines a
+          symbol or a symbol table), the implementation is expected to update
+          the cached symbol tables -- within the bufferization state -- to keep
+          them in a consistent state.
+
           Note: If this op supports unstructured control flow in its regions,
           then this function should also bufferize all block signatures that
           belong to this op. Branch ops (that branch to a block) are typically

``````````

</details>


https://github.com/llvm/llvm-project/pull/141594