[Mlir-commits] [mlir] [mlir][CMake] Modify the behavior of `add_mlir_aggregate ` and add `mlir_c_target_link_libraries`. (PR #141435)

Maksim Levental llvmlistbot at llvm.org
Mon May 26 09:52:08 PDT 2025


================
@@ -26,8 +26,11 @@ add_mlir_public_c_api_library(MLIRCAPIPythonTestDialect
   MLIRPythonTestIncGen
 
   LINK_LIBS PUBLIC
-  MLIRCAPIInterfaces
-  MLIRCAPIIR
----------------
makslevental wrote:

what i mean by breaking change is you now have to use `mlir_c_target_link_libraries` if you do `MLIR_BUILD_MLIR_C_DYLIB=1` otherwise strange things will happen (like whatever you mean by "polluting" up above). maybe it's not a breaking change because prior if you did `MLIR_BUILD_MLIR_C_DYLIB=1` (and prior `mlir_c_target_link_libraries` added here) nothing at all would happen but at least things would break break.

https://github.com/llvm/llvm-project/pull/141435


More information about the Mlir-commits mailing list