[Mlir-commits] [mlir] [mlir][CMake] Modify the behavior of `add_mlir_aggregate ` and add `mlir_c_target_link_libraries`. (PR #141435)
Fabian Mora
llvmlistbot at llvm.org
Mon May 26 09:35:51 PDT 2025
================
@@ -26,8 +26,11 @@ add_mlir_public_c_api_library(MLIRCAPIPythonTestDialect
MLIRPythonTestIncGen
LINK_LIBS PUBLIC
- MLIRCAPIInterfaces
- MLIRCAPIIR
----------------
fabianmcg wrote:
See:
```
mlir_c_target_link_libraries(MLIRCAPIPythonTestDialect
PUBLIC
MLIRCAPIInterfaces
MLIRCAPIIR
)
```
See as well https://github.com/llvm/llvm-project/pull/119408 for rationale
and https://github.com/llvm/llvm-project/blob/ce5ac91a3b0fc3cdf6fe9559c817d49df99e4263/mlir/cmake/modules/AddMLIR.cmake#L784-L802
Also, I'd argue test libraries never cause a breaking change. They are not for production.
https://github.com/llvm/llvm-project/pull/141435
More information about the Mlir-commits
mailing list