[Mlir-commits] [mlir] [mlir][Vector] Add `vector.to_elements` op (PR #141457)

[Andrzej Warzyński]

banach-space wrote:

Thanks, Diego! I’ve left a few minor comments inline. I also have one broader question.

> This op is aimed at reducing code size when modeling "structured" vector extractions and simplifying canonicalizations of large sequences of vector.extract and vector.insert ops into vector.shuffle and other sophisticated ops that can re-arrange vector elements.

That mostly makes sense, but I’m curious about the practical next steps and the overall direction we’re aiming for. Specifically:
* If `to_elements` + `from_elements` are intended to simplify existing logic, would that require significant refactoring? Do you anticipate any larger changes stemming from this?

Basically, I want to make sure we avoid "dangling" ops 😅  - currently, `vector.from_elements` isn't widely used.

https://github.com/llvm/llvm-project/pull/141457