[Mlir-commits] [mlir] [mlir][lsp] Enable registering dialects based on URI. (PR #141331)

[Jacques Pienaar]

jpienaar wrote:

> I assume it's not easy to write tests for this?

Not too difficult, but would require either introducing a new lsp binary or adding flag/convention to existing one.

E.g., I could make one where no dialects are registered if the file contains `_disable_lsp_registration` in its name and `MLIR_INCLUDE_TESTS` is set, and then just validating that parsing of the file fails. That means the regular mlir-lsp-server binary (which is semi combination of testing tool and example TBF - its very small making own LSP and probably everybody does to get their own dialects) only gets this while testing and so should have rather small overhead only when building with testing added, no extra binary and verifying this works. WDYT?

https://github.com/llvm/llvm-project/pull/141331