[Mlir-commits] [mlir] [mlir][TOSA] restore unrealized casts when lowering rescale ops (PR #141096)

[Thomas Preud'homme]

RoboTux wrote:

> > @RoboTux Only now that I've understood it's actually ArithToSPIRV that fails for you. Is there an mlir-opt repro that I could try for your case?
> 
> Nevermind, it must be something with our pipeline. I realized we are using the Arith to SPIR-V pattern but not the pass and were missing to mark the op as legal. Still now it fails in SPIRVLowerABIAttributesPass where we do use the upstream pass. But if this op is the right way to do it then this is just a _separate_ bug.

FYI (but again this is not your responsability) adding a conversion pattern from UnrealizedConversionCast to SPIRV's BitcastOp seems to solve my issues. Otherwise if we keep UnrealizedConversionCast then we need to teach the serializer about it but since SPIRV's bitcast seems to accept signedness cast I think we should just use it.

https://github.com/llvm/llvm-project/pull/141096