[Mlir-commits] [mlir] [mlir][memref][nfc] push early-exit to earlier (PR #140730)

[Andrzej Warzyński]

banach-space wrote:

Hey @Garra1980 , thanks for posting this and apologies if you're experiencing issues due to this PR.

> What was the rationale behind this change?

Early exits are [encouraged in LLVM](https://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code) and this looked like (and still does) like an NFC.

> no flow from %12 to memref_i8 which seems to be wrong

It's not quite clear to me what is wrong 😅  Could you compare _before_ and _after_ IR? If _after_ is indeed incorrect, we should include your example as a test and revert this change.

https://github.com/llvm/llvm-project/pull/140730