[Mlir-commits] [mlir] [MLIR] Determine contiguousness of memrefs with a dynamic dimension (PR #140872)

[James Newling]

https://github.com/newling commented:

Looks correct to me! I found the test of transfer_read

``` 
memref<1x4x?x6xi32> -> vector<1x2x6xi32> 
```

slightly confusing though, because the transfer_read itself is still contiguous because of the leading 1 in the vector shape (?).  Would it make sense to test this change in isolation by printing contiguity in final dimensions here 

https://github.com/llvm/llvm-project/blob/afd31339458967d3da9a04379f46f5e9ec1bb587/mlir/test/lib/Analysis/TestMemRefStrideCalculation.cpp#L55

or somewhere similar, and adding some tests somewhere here 

https://github.com/llvm/llvm-project/blob/afd31339458967d3da9a04379f46f5e9ec1bb587/mlir/test/Dialect/Affine/memref-stride-calculation.mlir#L77

?

https://github.com/llvm/llvm-project/pull/140872