[Mlir-commits] [mlir] [mlir] fix copying DialectRegistry and OperationState (PR #140963)

[llvmlistbot at llvm.org]

0xddom wrote:

> Is this expected that explicitly deleting these should change the behavior compared to have them implicitly deleted because of the unique_ptr member?

For `OperationState`, at least, looks like having the compiler implicitly remove them should be enough. However, I'm also running into this issue with the `StorageUniquer` class, where the copy constructor is left implicit. I'm trying to create Rust bindings for MLIR via [autocxx](https://github.com/google/autocxx) and the autogenerated code fails to compile because of calls to these copy constructors. I[raised an issue](https://github.com/google/autocxx/issues/1485) in their repo about this in case it's a bug on the tool.



https://github.com/llvm/llvm-project/pull/140963