[Mlir-commits] [mlir] Use ::llvm:LogicalResult instead of LogicalResult in FunctionInterfaces.td (PR #140965)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Wed May 21 15:13:52 PDT 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: spmok (siupakmok)

<details>
<summary>Changes</summary>

Fixed a minor typo, which can cause compile error:

error C3646: 'eraseResult': unknown override specifier

---
Full diff: https://github.com/llvm/llvm-project/pull/140965.diff


1 Files Affected:

- (modified) mlir/include/mlir/Interfaces/FunctionInterfaces.td (+1-1) 


``````````diff
diff --git a/mlir/include/mlir/Interfaces/FunctionInterfaces.td b/mlir/include/mlir/Interfaces/FunctionInterfaces.td
index cad0e790fdd97..4c8d5b02ed92a 100644
--- a/mlir/include/mlir/Interfaces/FunctionInterfaces.td
+++ b/mlir/include/mlir/Interfaces/FunctionInterfaces.td
@@ -332,7 +332,7 @@ def FunctionOpInterface : OpInterface<"FunctionOpInterface", [
 
     /// Erase a single result at `resultIndex`. Returns failure if the function
     /// cannot be updated to have the new signature.
-    LogicalResult eraseResult(unsigned resultIndex) {
+    ::llvm::LogicalResult eraseResult(unsigned resultIndex) {
       ::llvm::BitVector resultsToErase($_op.getNumResults());
       resultsToErase.set(resultIndex);
       return eraseResults(resultsToErase);

``````````

</details>


https://github.com/llvm/llvm-project/pull/140965


More information about the Mlir-commits mailing list