[Mlir-commits] [mlir] Use ::llvm:LogicalResult instead of LogicalResult in FunctionInterfaces.td (PR #140965)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Wed May 21 15:13:02 PDT 2025


https://github.com/siupakmok created https://github.com/llvm/llvm-project/pull/140965

Fixed a minor typo, which can cause compile error:

error C3646: 'eraseResult': unknown override specifier

>From d8297cca762aebab4695d2d4457153f72e4104e1 Mon Sep 17 00:00:00 2001
From: Siu Pak Mok <SiuPak.Mok at microchip.com>
Date: Wed, 21 May 2025 18:00:25 -0400
Subject: [PATCH] Use ::llvm:LogicalResult instead of LogicalResult in
 FunctionInterfaces.td

Fixed a minor typo, which can cause compile error:

error C3646: 'eraseResult': unknown override specifier
---
 mlir/include/mlir/Interfaces/FunctionInterfaces.td | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mlir/include/mlir/Interfaces/FunctionInterfaces.td b/mlir/include/mlir/Interfaces/FunctionInterfaces.td
index cad0e790fdd97..4c8d5b02ed92a 100644
--- a/mlir/include/mlir/Interfaces/FunctionInterfaces.td
+++ b/mlir/include/mlir/Interfaces/FunctionInterfaces.td
@@ -332,7 +332,7 @@ def FunctionOpInterface : OpInterface<"FunctionOpInterface", [
 
     /// Erase a single result at `resultIndex`. Returns failure if the function
     /// cannot be updated to have the new signature.
-    LogicalResult eraseResult(unsigned resultIndex) {
+    ::llvm::LogicalResult eraseResult(unsigned resultIndex) {
       ::llvm::BitVector resultsToErase($_op.getNumResults());
       resultsToErase.set(resultIndex);
       return eraseResults(resultsToErase);



More information about the Mlir-commits mailing list