[Mlir-commits] [mlir] [MLIR] Change getBackwardSlice to return a logicalresult rather than … (PR #140961)

Oleksandr Alex Zinenko llvmlistbot at llvm.org
Wed May 21 14:38:03 PDT 2025


================
@@ -112,7 +112,8 @@ bool BackwardSliceMatcher<Matcher>::matches(
     }
     return true;
   };
-  getBackwardSlice(rootOp, &backwardSlice, options);
+  auto result = getBackwardSlice(rootOp, &backwardSlice, options);
----------------
ftynse wrote:

```suggestion
  LogicalResult result = getBackwardSlice(rootOp, &backwardSlice, options);
```

expand `auto` unless the type is obvious from statement-level context or obnoxious to spell out.

https://github.com/llvm/llvm-project/pull/140961


More information about the Mlir-commits mailing list