[Mlir-commits] [mlir] [MLIR] Change getBackwardSlice to return a logicalresult rather than … (PR #140961)

Oleksandr Alex Zinenko llvmlistbot at llvm.org
Wed May 21 14:38:03 PDT 2025


================
@@ -124,10 +124,13 @@ static void computeBackwardSlice(tensor::PadOp padOp,
   getUsedValuesDefinedAbove(padOp.getRegion(), padOp.getRegion(),
                             valuesDefinedAbove);
   for (Value v : valuesDefinedAbove) {
-    getBackwardSlice(v, &backwardSlice, sliceOptions);
+    auto result = getBackwardSlice(v, &backwardSlice, sliceOptions);
+    assert(result.succeeded());
   }
   // Then, add the backward slice from padOp itself.
-  getBackwardSlice(padOp.getOperation(), &backwardSlice, sliceOptions);
+  auto result =
+      getBackwardSlice(padOp.getOperation(), &backwardSlice, sliceOptions);
+  assert(result.succeeded());
----------------
ftynse wrote:

```suggestion
  LogicalResult result =
      getBackwardSlice(padOp.getOperation(), &backwardSlice, sliceOptions);
  assert(result.succeeded() && "expected a backward slice");
```

https://github.com/llvm/llvm-project/pull/140961


More information about the Mlir-commits mailing list