[Mlir-commits] [mlir] [mlir] Add missing add_mlir_library_install() to tool libraries (PR #140880)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Wed May 21 03:46:41 PDT 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-core

Author: Martin Valgur (valgur)

<details>
<summary>Changes</summary>

The corresponding tools can only be run when the libraries are built as static currently due to this. I'm assuming this was not intentional.

---
Full diff: https://github.com/llvm/llvm-project/pull/140880.diff


3 Files Affected:

- (modified) mlir/lib/Tools/PDLL/Parser/CMakeLists.txt (+2) 
- (modified) mlir/lib/Tools/mlir-pdll-lsp-server/CMakeLists.txt (+2) 
- (modified) mlir/lib/Tools/tblgen-lsp-server/CMakeLists.txt (+2) 


``````````diff
diff --git a/mlir/lib/Tools/PDLL/Parser/CMakeLists.txt b/mlir/lib/Tools/PDLL/Parser/CMakeLists.txt
index 7953677d1957e..6cf2ba5f864bc 100644
--- a/mlir/lib/Tools/PDLL/Parser/CMakeLists.txt
+++ b/mlir/lib/Tools/PDLL/Parser/CMakeLists.txt
@@ -15,3 +15,5 @@ llvm_add_library(MLIRPDLLParser STATIC
   MLIRSupport
   MLIRTableGen
   )
+
+add_mlir_library_install(MLIRPDLLParser)
diff --git a/mlir/lib/Tools/mlir-pdll-lsp-server/CMakeLists.txt b/mlir/lib/Tools/mlir-pdll-lsp-server/CMakeLists.txt
index bf25b7e0a64f3..c81c147e32223 100644
--- a/mlir/lib/Tools/mlir-pdll-lsp-server/CMakeLists.txt
+++ b/mlir/lib/Tools/mlir-pdll-lsp-server/CMakeLists.txt
@@ -12,3 +12,5 @@ llvm_add_library(MLIRPdllLspServerLib
   MLIRPDLLParser
   MLIRLspServerSupportLib
   )
+
+add_mlir_library_install(MLIRPdllLspServerLib)
diff --git a/mlir/lib/Tools/tblgen-lsp-server/CMakeLists.txt b/mlir/lib/Tools/tblgen-lsp-server/CMakeLists.txt
index 80fc1ffe4029a..4e7b3310fee65 100644
--- a/mlir/lib/Tools/tblgen-lsp-server/CMakeLists.txt
+++ b/mlir/lib/Tools/tblgen-lsp-server/CMakeLists.txt
@@ -18,3 +18,5 @@ llvm_add_library(TableGenLspServerLib
   MLIRLspServerSupportLib
   MLIRSupport
   )
+
+add_mlir_library_install(TableGenLspServerLib)

``````````

</details>


https://github.com/llvm/llvm-project/pull/140880


More information about the Mlir-commits mailing list