[Mlir-commits] [mlir] [MLIR][LLVM] Tail call support for inline asm op (PR #140826)

[Christian Ulmann]

================
@@ -2201,6 +2201,10 @@ LogicalResult ModuleImport::convertInstruction(llvm::Instruction *inst) {
                 builder.getStringAttr(asmI->getAsmString()),
                 builder.getStringAttr(asmI->getConstraintString()),
                 asmI->hasSideEffects(), asmI->isAlignStack(),
+                callInst->isTailCall()
+                    ? TailCallKindAttr::get(mlirModule.getContext(),
+                                            TailCallKind::Tail)
----------------
Dinistro wrote:

This implies that there is only one supported kind. If so, would it make sense to model this simply as a unit attribute instead of supporting the enum but only one value of it?

https://github.com/llvm/llvm-project/pull/140826