[Mlir-commits] [mlir] [MLIR][ArmSVE] Add initial lowering of vector.contract to SVE `*MMLA` instructions (PR #135636)

[Andrzej Warzyński]

https://github.com/banach-space commented:

A few more questions/suggestions inline. In general, I would appreciate a few more comments with ASCII - these tend to be super helpful :) 🙏🏻 

One other high-level comment, why not incorporate the test changes from https://github.com/llvm/llvm-project/pull/140572 in this patch? If 140572 implements the end state (that would be my preference) then lets use that. The TD op can still be upstreamed as a separate change.

All in all, this is already very polished and nicely crafted, well done!

https://github.com/llvm/llvm-project/pull/135636