[Mlir-commits] [mlir] [MLIR] Add apply_patterns.vector.arm_neon.lower_contraction TD Op (PR #140251)

Andrzej WarzyƄski llvmlistbot at llvm.org
Tue May 20 09:24:41 PDT 2025


https://github.com/banach-space approved this pull request.

LGTM, thanks!

I've left a couple of small suggestion inline. One larger suggestion - I would drop `vector` from the Op name. To me, this is the naming scheme:
* `apply_patterns.{dialect}.{meta-name-for-patterns}`

This will help us avoid "polluting" the "Vector" namespace with things specific to hardware targets.

https://github.com/llvm/llvm-project/pull/140251


More information about the Mlir-commits mailing list