[Mlir-commits] [mlir] [MLIR][Linalg] Fix insert_slice fusion with rank reduction (PR #130961)

Andrzej Warzyński llvmlistbot at llvm.org
Tue May 20 09:09:46 PDT 2025


================

----------------
banach-space wrote:

Thanks for simplifying this test!

Could you introduce some more descriptive var names so that it is easier to parse? (and consistent with other tests). I would probably limit this to:
* Function input variables (e.g. `%arg0 --> `%lhs_1`, `%arg1` -> `%rhs_1`, `%arg2` -> `%lhs_2`, `%arg3`->`%out1` etc)
* High-level ops (`scf.for` + `linalg.generic`)

Hopefully that's not too much work 😅 I won't be requesting any further changes after this.

https://github.com/llvm/llvm-project/pull/130961


More information about the Mlir-commits mailing list