[Mlir-commits] [mlir] Fix support for complex types in `transform.structured.pad` (PR #139841)

[Andrzej Warzyński]

================

----------------
banach-space wrote:

Rather than adding a completely new test case, could you re-use or modify one of the existing ones? Otherwise, it’s harder to see what makes the new test "special" or "unique" - modifying an existing test often makes it easier to highlight the impact of a change.

That said, I don’t see any truly “basic” cases for padding linalg.matmul, so it’s reasonable if you need to create your own. Alternatively, you might be able to re-use one of the `pad_to_multiple_of` tests. I'm not very familiar with `transform.structured.pad`, but do you actually rely on `pad_to_multiple_of` to verify this change?

Separately, please make sure your test is self-documenting - for example, consider renaming `@pad_matmul` to something more descriptive. You can find relevant testing guidelines here:

* https://mlir.llvm.org/getting_started/TestingGuide/#contributor-guidelines

Thanks!

https://github.com/llvm/llvm-project/pull/139841