[Mlir-commits] [mlir] [mlir] Allow folding dynamic full size subviews (PR #140619)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue May 20 07:32:06 PDT 2025


================
@@ -3206,7 +3215,7 @@ class TrivialSubViewOpFolder final : public OpRewritePattern<SubViewOp> {
 
   LogicalResult matchAndRewrite(SubViewOp subViewOp,
                                 PatternRewriter &rewriter) const override {
-    if (!isTrivialSubViewOp(subViewOp))
+    if (!isTrivialSubViewOp(rewriter, subViewOp))
       return failure();
----------------
Max191 wrote:

After looking into it further, I do see some instances of ValueBoundsOpInterface being used in canonicalization patterns, so I suppose it is the lesser of the two evils. I will update the PR implementation to use it instead.

https://github.com/llvm/llvm-project/pull/140619


More information about the Mlir-commits mailing list