https://github.com/banach-space approved this pull request. Thanks for addressing my comments, LGTM I've left a couple of small suggestion, could you incorporate them before landing? Thanks! https://github.com/llvm/llvm-project/pull/138984