[Mlir-commits] [mlir] [MLIR] Minor fixes to FoldTransposeBroadcast rewrite (NFC) (PR #140083)

[James Newling]

newling wrote:

> > > Can you try building `mlir-opt` with `-DMLIR_ENABLE_EXPENSIVE_PATTERN_API_CHECKS=On`? With expensive checks on, `mlir-opt` should fail.
> > 
> > 
> > I've just tried this and yes, it fails. That's a useful flag, thanks for point this out @banach-space! Should there be a build in CI with this on?
> 
> All the builders are defined here:
> 
> * https://github.com/llvm/llvm-zorg/tree/main
> 
> Unfortunately, searching for `MLIR_ENABLE_EXPENSIVE_PATTERN_API_CHECKS` gives no hits. I'm hesitant to enable this in one of the existing Arm builders, since I worry it might be too fragile and break frequently.
> 
> I'll look into whether we can add a dedicated builder for this - but please don’t hold your breath; these things can take time.

Thanks @banach-space that might be useful, do let me know if I can help 

https://github.com/llvm/llvm-project/pull/140083