[Mlir-commits] [mlir] [mlir] Use llvm::replace (NFC) (PR #140344)

Kazu Hirata llvmlistbot at llvm.org
Fri May 16 20:31:19 PDT 2025


https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/140344

None

>From 68b29eb3b0567458b561b9cdda87fef4d60d748e Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Fri, 16 May 2025 20:10:18 -0700
Subject: [PATCH] [mlir] Use llvm::replace (NFC)

---
 mlir/lib/Dialect/LLVMIR/IR/BasicPtxBuilderInterface.cpp | 2 +-
 mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp                | 2 +-
 mlir/lib/Transforms/ViewOpGraph.cpp                     | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/mlir/lib/Dialect/LLVMIR/IR/BasicPtxBuilderInterface.cpp b/mlir/lib/Dialect/LLVMIR/IR/BasicPtxBuilderInterface.cpp
index b109f00c3da13..f2e71e7795c3e 100644
--- a/mlir/lib/Dialect/LLVMIR/IR/BasicPtxBuilderInterface.cpp
+++ b/mlir/lib/Dialect/LLVMIR/IR/BasicPtxBuilderInterface.cpp
@@ -130,7 +130,7 @@ LLVM::InlineAsmOp PtxBuilder::build() {
 
   // Tablegen doesn't accept $, so we use %, but inline assembly uses $.
   // Replace all % with $
-  std::replace(ptxInstruction.begin(), ptxInstruction.end(), '%', '$');
+  llvm::replace(ptxInstruction, '%', '$');
 
   return rewriter.create<LLVM::InlineAsmOp>(
       interfaceOp->getLoc(),
diff --git a/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp b/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
index 96106cf7ae120..8a8bd5e232c40 100644
--- a/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
+++ b/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
@@ -2402,7 +2402,7 @@ std::string mlir::linalg::generateLibraryCallName(Operation *op) {
     }
   }
   name.reserve(128);
-  std::replace(name.begin(), name.end(), '.', '_');
+  llvm::replace(name, '.', '_');
   llvm::raw_string_ostream ss(name);
   ss << "_" << fun;
   for (Type t : op->getOperandTypes()) {
diff --git a/mlir/lib/Transforms/ViewOpGraph.cpp b/mlir/lib/Transforms/ViewOpGraph.cpp
index 75ee3ed74db5e..28fe2a7501c06 100644
--- a/mlir/lib/Transforms/ViewOpGraph.cpp
+++ b/mlir/lib/Transforms/ViewOpGraph.cpp
@@ -292,8 +292,8 @@ class PrintOpPass : public impl::ViewOpGraphBase<PrintOpPass> {
       operand.printAsOperand(os, OpPrintingFlags());
     });
     // Replace % and # with _
-    std::replace(str.begin(), str.end(), '%', '_');
-    std::replace(str.begin(), str.end(), '#', '_');
+    llvm::replace(str, '%', '_');
+    llvm::replace(str, '#', '_');
     return str;
   }
 



More information about the Mlir-commits mailing list