[Mlir-commits] [mlir] [mlir][bufferization] implement BufferizableOpInterface for concat op (PR #140171)

[LLVM Continuous Integration]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `mlir-s390x-linux` running on `systemz-1` while building `mlir` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/117/builds/9670

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
58.283 [802/4/4027] Building TestOps.19.cpp...
58.285 [801/4/4028] Building TestOps.2.cpp...
58.290 [800/4/4029] Building TestOps.20.cpp...
58.294 [799/4/4030] Building TestOps.4.cpp...
58.299 [798/4/4031] Building TestOps.5.cpp...
58.301 [797/4/4032] Building TestOps.6.cpp...
58.305 [796/4/4033] Building TestOps.7.cpp...
58.309 [795/4/4034] Building TestOps.8.cpp...
58.312 [794/4/4035] Building TestOps.9.cpp...
58.410 [793/4/4036] Building CXX object tools/mlir/lib/Dialect/Tensor/Transforms/CMakeFiles/obj.MLIRTensorTransforms.dir/BufferizableOpInterfaceImpl.cpp.o
FAILED: tools/mlir/lib/Dialect/Tensor/Transforms/CMakeFiles/obj.MLIRTensorTransforms.dir/BufferizableOpInterfaceImpl.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes CCACHE_SLOPPINESS=pch_defines,time_macros /usr/bin/ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/tools/mlir/lib/Dialect/Tensor/Transforms -I/home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/lib/Dialect/Tensor/Transforms -I/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/tools/mlir/include -I/home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/include -I/home/uweigand/sandbox/buildbot/mlir-s390x-linux/build/include -I/home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wno-unnecessary-virtual-specifier -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wundef -Wno-unused-but-set-parameter -Wno-deprecated-copy -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/mlir/lib/Dialect/Tensor/Transforms/CMakeFiles/obj.MLIRTensorTransforms.dir/BufferizableOpInterfaceImpl.cpp.o -MF tools/mlir/lib/Dialect/Tensor/Transforms/CMakeFiles/obj.MLIRTensorTransforms.dir/BufferizableOpInterfaceImpl.cpp.o.d -o tools/mlir/lib/Dialect/Tensor/Transforms/CMakeFiles/obj.MLIRTensorTransforms.dir/BufferizableOpInterfaceImpl.cpp.o -c /home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/lib/Dialect/Tensor/Transforms/BufferizableOpInterfaceImpl.cpp
/home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/lib/Dialect/Tensor/Transforms/BufferizableOpInterfaceImpl.cpp: In member function 'llvm::LogicalResult mlir::tensor::{anonymous}::ConcatOpInterface::bufferize(mlir::Operation*, mlir::RewriterBase&, const mlir::bufferization::BufferizationOptions&) const':
/home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/lib/Dialect/Tensor/Transforms/BufferizableOpInterfaceImpl.cpp:1097:54: error: 'ToMemrefOp' is not a member of 'mlir::bufferization'
 1097 |     Value dstBuffer = rewriter.create<bufferization::ToMemrefOp>(
      |                                                      ^~~~~~~~~~
/home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/lib/Dialect/Tensor/Transforms/BufferizableOpInterfaceImpl.cpp:1097:65: error: no matching function for call to 'mlir::RewriterBase::create<<expression error> >(mlir::Location, mlir::MemRefType&, mlir::Value&)'
 1097 |     Value dstBuffer = rewriter.create<bufferization::ToMemrefOp>(
      |                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
 1098 |         op->getLoc(), memrefType, *tensorAlloc);
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                  
In file included from /home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/include/mlir/Interfaces/InferTypeOpInterface.h:18,
                 from /home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/include/mlir/Dialect/Arith/IR/Arith.h:19,
                 from /home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/include/mlir/Dialect/Affine/IR/AffineOps.h:18,
                 from /home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/lib/Dialect/Tensor/Transforms/BufferizableOpInterfaceImpl.cpp:11:
/home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/include/mlir/IR/Builders.h:503:8: note: candidate: 'template<class OpTy, class ... Args> OpTy mlir::OpBuilder::create(mlir::Location, Args&& ...)'
  503 |   OpTy create(Location location, Args &&...args) {
      |        ^~~~~~
/home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/include/mlir/IR/Builders.h:503:8: note:   template argument deduction/substitution failed:
/home/uweigand/sandbox/buildbot/mlir-s390x-linux/llvm-project/mlir/lib/Dialect/Tensor/Transforms/BufferizableOpInterfaceImpl.cpp:1097:65: error: template argument 1 is invalid
 1097 |     Value dstBuffer = rewriter.create<bufferization::ToMemrefOp>(
      |                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
 1098 |         op->getLoc(), memrefType, *tensorAlloc);
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~                  
At global scope:
cc1plus: note: unrecognized command-line option '-Wno-unnecessary-virtual-specifier' may have been intended to silence earlier diagnostics
58.423 [793/3/4037] Building TestOps.cpp.inc...
58.445 [793/2/4038] Building TestOps.h.inc...
60.897 [793/1/4039] Building CXX object tools/mlir/lib/Dialect/Tensor/IR/CMakeFiles/obj.MLIRTensorDialect.dir/TensorDialect.cpp.o
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/140171