[Mlir-commits] [mlir] [MLIR] Minor fixes to FoldTransposeBroadcast rewrite (NFC) (PR #140083)

[Diego Caballero]

dcaballe wrote:

Let's see if I follow... we initially generate:

```
 %bcast = vector.broadcast %value : f32 to vector<8x1xf32>
  %t = vector.broadcast %bcast  : vector<8x1xf32> to vector<1x8xf32>
```

but the CHECK rules don't fail:

```
//  CHECK-SAME: (%[[ARG:.+]]: f32)
//       CHECK:   %[[V:.+]] = vector.broadcast %[[ARG]] : f32 to vector<1x8xf32>
//       CHECK:   return %[[V]] : vector<1x8xf32>
```

because there is another folding that is turning the two invalid `vector.broadcast` ops into a single but valid one, and the intermediate state is not verified without the expensive checks?

Yeah, having a buildbot covering this would be awesome.

https://github.com/llvm/llvm-project/pull/140083