[Mlir-commits] [mlir] [MLIR][Linalg] Fix insert_slice fusion with rank reduction (PR #130961)

[Andrzej Warzyński]

https://github.com/banach-space commented:

To me this makes sense, thanks for the discussion and apologies for the delay!

I've left a few comments inline, but I also have two higher-level suggestion:
* Move `dropGivenUnitDims` to mlir/lib/Dialect/Tensor/Utils.cpp -> this hook is a fairly generic helper.
* The test that's added here is quite complex - could you try simplifying it? In principle, the only thing that matters is "rank reduction", everything else (e.g. other ops) is creating noise. I've made some suggestions inline.

Let me also ping @qedawkins and @javedabsar , who are experts in this area :)

https://github.com/llvm/llvm-project/pull/130961