[Mlir-commits] [mlir] [mli][vector] canonicalize vector.from_elements from ascending extracts (PR #139819)

Andrzej WarzyƄski llvmlistbot at llvm.org
Fri May 16 09:41:31 PDT 2025


================
@@ -2385,9 +2386,105 @@ static LogicalResult rewriteFromElementsAsSplat(FromElementsOp fromElementsOp,
   return success();
 }
 
+/// Rewrite vector.from_elements as vector.shape_cast, if possible.
----------------
banach-space wrote:

[ultra nit] "if possible" is implicit and "less is more" :)
```suggestion
/// Rewrite vector.from_elements as vector.shape_cast.
```

https://github.com/llvm/llvm-project/pull/139819


More information about the Mlir-commits mailing list