[Mlir-commits] [mlir] [mlir][builtin] Make `unrealized_conversion_cast` inlineable (PR #139722)

[Jeremy Kun]

j2kun wrote:

> @j2kun Actually, this doesn't make modules inlineable because modules cannot be called. (There's no op that calls a module.)

I don't understand what you mean. There is no op that calls an `unrealized_conversion_cast`, but you are making that op inlineable.

> The fact that a module can be nested within a `func.func` seems like a input IR issue to me.

I agree, though I don't particularly care one way or the other. My main concern is the discrepancy between what the PR says it does (make one op inlineable) and what it actually does (make all ops in a dialect inlineable, including future ops), as that can imply unintended behavior changes. If, as I suspect, making the entire dialect inlineable is the right thing to do, all I ask is to update the commit/PR metadata :)

https://github.com/llvm/llvm-project/pull/139722