[Mlir-commits] [mlir] [mlir][OpenMP] add attribute for privatization barrier (PR #140089)

[Tom Eccles]

================
@@ -824,15 +839,15 @@ static ParseResult parseTargetOpRegion(
     SmallVectorImpl<Type> &mapTypes,
     llvm::SmallVectorImpl<OpAsmParser::UnresolvedOperand> &privateVars,
     llvm::SmallVectorImpl<Type> &privateTypes, ArrayAttr &privateSyms,
-    DenseI64ArrayAttr &privateMaps) {
+    UnitAttr &privateNeedsBarrier, DenseI64ArrayAttr &privateMaps) {
----------------
tblah wrote:

The distinction is generally where this could be confused with future `needsBarrier` members for other clauses in that context. For example, there is no need for a "private" prefix inside of `PrivateParseArgs` but there is ambiguity in `parseTargetOpRegion` because there could one day be `needsBarrier` members for other clauses on TARGET.

Similar naming choices are used for `privateSyms` and `privateVars`. I believe my current usage is consistent with those other variables.

https://github.com/llvm/llvm-project/pull/140089