[Mlir-commits] [mlir] [mlir][Vector] Improve `vector.mask` verifier (PR #139823)

[Andrzej Warzyński]

================
@@ -6603,9 +6605,8 @@ LogicalResult MaskOp::verify() {
                        "number of results");
 
   if (!llvm::equal(maskableOp->getResults(), terminator.getOperands()))
-    return emitOpError(
-        "expects all the results from the MaskableOpInterface to "
-        "be returned by the terminator");
+    return emitOpError("expects all the results from the MaskableOpInterface "
+                       "to match all the values returned by the terminator");
----------------
banach-space wrote:

After seeing the comment from @newling , I've realised that we are special-casing an empty `vector.mask`. This example will not trigger the error: 

```mlir
%0 = vector.mask %mask { vector.yield %a : vector<8xf32> } : vector<8xi1> -> vector<8xf32>
```

That's a bit of inconsistency. Perhaps leave a TODO to address this at some point? 

https://github.com/llvm/llvm-project/pull/139823