[Mlir-commits] [mlir] [mlir][LLVM] handle ArrayAttr for constant array of structs (PR #139724)

[Tobias Gysi]

https://github.com/gysit approved this pull request.

Thanks for addressing the comments.

LGTM module nits.

I think the verifier is more readable now and the compromise in terms of verification quality seem ok. At a first glance, it also looks like the LLVM IR import should not be able to produce code that does not pass the new verifier (let's see if this statement survives the test of time...).

Let's give other reviewers some time tomorrow to follow-up should there be concerns.


https://github.com/llvm/llvm-project/pull/139724