[Mlir-commits] [mlir] [mlir][Vector] Improve `vector.mask` verifier (PR #139823)
Andrzej WarzyĆski
llvmlistbot at llvm.org
Wed May 14 08:02:49 PDT 2025
================
@@ -6600,6 +6602,11 @@ LogicalResult MaskOp::verify() {
return emitOpError("expects number of results to match maskable operation "
"number of results");
+ if (!llvm::equal(maskableOp->getResults(), terminator.getOperands()))
+ return emitOpError(
+ "expects all the results from the MaskableOpInterface to "
+ "be returned by the terminator");
----------------
banach-space wrote:
This will trigger even when "all the results from the MaskableOpInterface" _are_ returned by the terminator.
```suggestion
"expects all the results from the MaskableOpInterface to "
"match all the values returned by the terminator");
```
https://github.com/llvm/llvm-project/pull/139823
More information about the Mlir-commits
mailing list