[Mlir-commits] [mlir] [mlir][LLVM] handle ArrayAttr for constant array of structs (PR #139724)

[llvmlistbot at llvm.org]

jeanPerier wrote:

> I think highest priority is probably trying to make the verifier more readable.

I refactored the verifier code to check array of struct attribute in a helper, which allow recursive checking of sub-dimension making things clearer.

I restricted the verifier to reject ArrayAttr for array of simple element types, and removed the handling of vector type from my code since it does not make sense to have vectors of structs.

I also added support and tests for undef/zero attributes appearing in some dimension or struct element field since I do need this in my flang use case.

https://github.com/llvm/llvm-project/pull/139724