[Mlir-commits] [mlir] [MLIR][LLVM] Fix blockaddress mapping to LLVM blocks (PR #139814)

[Christian Ulmann]

================
@@ -142,21 +142,21 @@ class ModuleTranslation {
     auto result = unresolvedBlockAddressMapping.try_emplace(op, cst);
     (void)result;
     assert(result.second &&
-           "attempting to map a blockaddress that is already mapped");
+           "attempting to map a blockaddress operation that is already mapped");
   }
 
-  /// Maps a blockaddress operation to its corresponding placeholder LLVM
-  /// value.
-  void mapBlockTag(BlockAddressAttr attr, BlockTagOp blockTag) {
-    // Attempts to map already mapped block labels which is fine if the given
-    // labels are verified to be unique.
-    blockTagMapping[attr] = blockTag;
+  /// Maps a BlockAddressAttr to its corresponding LLVM basic block.
+  void mapBlockAddress(BlockAddressAttr attr, llvm::BasicBlock *block) {
+    auto result = blockAddressToLLVMMapping.try_emplace(attr, block);
+    (void)result;
+    assert(
+        result.second &&
+        "attempting to map a blockaddress attritbute that is already mapped");
----------------
Dinistro wrote:

```suggestion
        "attempting to map a blockaddress attribute that is already mapped");
```

https://github.com/llvm/llvm-project/pull/139814