[Mlir-commits] [mlir] [mlir][vector] Address linearization comments (post commit) (PR #138075)

[James Newling]

================
@@ -447,18 +444,22 @@ struct LinearizeVectorSplat final
 
 } // namespace
 
-/// Return true if the operation `op` does not support scalable vectors and
-/// has at least 1 scalable vector result. These ops should all eventually
-/// support scalable vectors, and this function should be removed.
+/// Some operations currently will not be linearized if they have scalable
+/// vector results, although support should be added in the future. This
+/// function returns true if `op` is such an operation.
----------------
newling wrote:

> Could you update these comments accordingly?

Your explanation is much clearer, I'll update.

> is there an example where non-scalable result (with some operands are scalable) makes an operation "linearizable"?

I can't think of any ops which have scalable operand and non-scalable result:
```
%1 = foo %0 : vector<[4]xi8> -> vector<8xi8>
```
? Let me update the entire `isNotLinearizableBecauseScalable` function, then you can take another look to see if could be improved further. 

https://github.com/llvm/llvm-project/pull/138075