[Mlir-commits] [mlir] [mlir][vector] Additional transpose folding (PR #138347)

[Andrzej Warzyński]

================
@@ -247,3 +247,36 @@ func.func @negative_shape_cast_transpose(%arg : vector<6xi8>) -> vector<2x3xi8>
   %1 = vector.transpose %0, [1, 0] : vector<3x2xi8> to vector<2x3xi8>
   return %1 : vector<2x3xi8>
 }
+
+// -----
+
+// Test of transpose folding
----------------
banach-space wrote:

I have just noticed that you add this note to every test - thanks! Nit suggestion - why not add block comments, e.g.:
https://github.com/llvm/llvm-project/blob/0009a1783490a8ff69251a0ec7df1891a427cfb0/mlir/test/Dialect/Vector/vector-transfer-drop-unit-dims-patterns.mlir#L3-L5

The actual format is secondary - my main suggestion would be to avoid duplicating the same comment and to create "sections" to group similar tests together. Especially given that this file keeps growing 😅 

https://github.com/llvm/llvm-project/pull/138347