[Mlir-commits] [mlir] [NFC][mlir][spirv] Sync GroupNonUniformRotateKHR format with other non-uniform ops (PR #139224)

Hsiangkai Wang llvmlistbot at llvm.org
Fri May 9 03:04:19 PDT 2025


Hsiangkai wrote:

> For what my approval is worth: LGTM
> 
> One thought: Should it be tagged [NFC]? It changes assembly format, so it impacts parsers, printers, etc. potentially breaking downstream users having code written in the old format. I'd be inclined to say it's a functional change, but I'm happy to be corrected :)

You are right. It updates the syntax even the semantic of the operation is the same. I also have test cases updated in this patch. I removed NFC tag as you suggested. Thanks for your review.

https://github.com/llvm/llvm-project/pull/139224


More information about the Mlir-commits mailing list