[Mlir-commits] [mlir] [MLIR][NVVM] Add support for dp4a instructions (PR #139043)

[Durgadoss R]

================
@@ -1590,6 +1597,17 @@ static void nvvmInferResultRanges(Operation *op, Value result,
   }
 }
 
+#define GET_DP4A_ID(a_sign, is_b_siext)                                        \
+  is_b_siext ? llvm::Intrinsic::nvvm_idp4a_##a_sign##_s                        \
+             : llvm::Intrinsic::nvvm_idp4a_##a_sign##_u
----------------
durga4github wrote:

+1. For this one here, can we just use a simple if-else for all the 4 combinations?
```
if (a_signed && b_signed)
  IID = nvvm_idp4a_s_s;
else if (a_signed)
  IID = nvvm_idp4a_s_u;
else if (b_signed)
  IID = nvvm_idp4a_u_s;
else
  IID = nvvm_idp4a_u_u;
```

https://github.com/llvm/llvm-project/pull/139043