[Mlir-commits] [mlir] [MLIR][NVVM] Add support for dp4a instructions (PR #139043)

[Durgadoss R]

================
@@ -1590,6 +1590,14 @@ static void nvvmInferResultRanges(Operation *op, Value result,
   }
 }
 
+#define GET_DP4A_ID(a_sign, is_b_signed)                                       \
+  is_b_signed ? llvm::Intrinsic::nvvm_idp4a_##a_sign##_s                       \
+              : llvm::Intrinsic::nvvm_idp4a_##a_sign##_u
+
+llvm::Intrinsic::ID Dp4aOp::getIntrinsicID(bool a_signed, bool b_signed) {
+  return a_signed ? GET_DP4A_ID(s, b_signed) : GET_DP4A_ID(u, b_signed);
----------------
durga4github wrote:

Can we use GET_ID(is_a_signed, is_b_signed) ?
Since this is only 4 individual intrinsics, a simple lambda (without any macro) will be cleaner

https://github.com/llvm/llvm-project/pull/139043