[Mlir-commits] [llvm] [mlir] [OMPIRBuilder] - Make offloading input data persist for deferred target tasks (PR #133499)

Sergio Afonso llvmlistbot at llvm.org
Thu May 8 05:50:52 PDT 2025


https://github.com/skatrak commented:

Thank you Pranav for this work, the approach makes sense to me. I have a few comments, but most of them are just small nits.

I think it would be good to check in some of the existing or new Lit tests that the new expected `memcpy` calls and GEP instructions to initialize structures are introduced, and that the right GEP instructions are used to access that data back from within the corresponding outlined functions.

https://github.com/llvm/llvm-project/pull/133499


More information about the Mlir-commits mailing list