[Mlir-commits] [mlir] [mlir][tblgen] Add custom parsing and printing within struct (PR #133939)

[Jorn Tuyls]

jtuyls wrote:

> @jtuyls @joker-eph I've landed [441b683](https://github.com/llvm/llvm-project/commit/441b68370a2fb97c1a650de15528e5600eacab6b) to fix a warning from this PR. Would you mind checking to see if you actually don't intend to use `realParam`, the result of `dyn_cast`, inside the `if` statement? Thanks!
> 
> ```
>     if (isa<ParameterElement>(arg))
>       genVariableParser(param, ctx, os.indent());
> ```

Thanks for the fix and heads up on the change! I think it's fine as `realParam` would actually be the same as `param`, so your change would be functionally equivalent to:
````
if (auto realParam = dyn_cast<ParameterElement>(arg))
      genVariableParser(realParam, ctx, os.indent());
```


https://github.com/llvm/llvm-project/pull/133939