[Mlir-commits] [mlir] [MLIR] Check that the prop-dict dictionnary does not have extra unknown entries (PR #138668)

[River Riddle]

================
@@ -1310,6 +1315,7 @@ auto setFromAttr = [] (auto &propStorage, ::mlir::Attribute propAttr,
          ::llvm::function_ref<::mlir::InFlightDiagnostic()> emitError) -> ::mlir::LogicalResult {{
   {0};
 };
+usedKeys.insert(StringAttr::get(ctx, "{1}"));
----------------
River707 wrote:

Is this going to create two StringAttrs? dict.get will likely create one as well, same below

https://github.com/llvm/llvm-project/pull/138668