[Mlir-commits] [clang] [mlir] [OpenACC] Implement tile/collapse lowering (PR #138576)

[Erich Keane]

================
@@ -82,6 +83,17 @@ class OpenACCClauseCIREmitter final
     return conversionOp.getResult(0);
   }
 
+  mlir::Value createConstantInt(mlir::Location loc, unsigned width,
+                                int64_t value) {
+    mlir::IntegerType ty = mlir::IntegerType::get(
+        &cgf.getMLIRContext(), width,
+        mlir::IntegerType::SignednessSemantics::Signless);
+    auto constOp = builder.create<mlir::arith::ConstantOp>(
+        loc, ty, builder.getIntegerAttr(ty, value));
----------------
erichkeane wrote:

As these are mlir types, do you think it makes sense to go modify the MLIR types for this canonicalization?  Really it doesn't affect anything, but it just seemed like we were creating more than we should have, and I wanted to make sure that wasn't problematic.

https://github.com/llvm/llvm-project/pull/138576