[Mlir-commits] [mlir] [MLIR] Folding unpack and pack sequence in data layout propagation (PR #138332)

[Han-Chung Wang]

https://github.com/hanhanW requested changes to this pull request.

I'm surprised that we are using the pass, but I'm also happy about that. I wrote it long long time ago, and there are no new patches for a while. :)

However, do we need the patch? We have folding for `pack->unpack` ops in canonicalization patterns. The missing feature seems to be that we can reuse the pack's destination tensor in the propagation. 

https://github.com/llvm/llvm-project/blob/e8825900838a11afe326e202d19a3df6e3408422/mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp#L4918-L4928


https://github.com/llvm/llvm-project/pull/138332