[Mlir-commits] [mlir] [mlir][vector] Add linearization pattern for vector.splat (PR #137651)

[James Newling]

newling wrote:

> Kind request 🙏🏻
> 
> If you're landing a patch without an explicit LGTM from an active reviewer (i.e., someone who has provided comments), please consider adding a brief note such as:
> 
> > “All comments from @user-name have been addressed, hence landing without explicit LGTM.”
> 
> Per [LLVM’s code review policy](https://llvm.org/docs/CodeReview.html#lgtm-how-a-patch-is-accepted):
> 
> > When providing an unqualified LGTM (approval to commit), it is the responsibility of the reviewer to have reviewed all of the prior discussion and feedback from all reviewers ensuring that all feedback has been addressed and that all other reviewers will almost surely be satisfied with the patch being approved.
> 
> While not strictly required, I’d really appreciate this small courtesy. It helps maintain clarity, smooth collaboration, and avoids surprises.
> 
> From my perspective, a patch that:
> 
> * I’ve reviewed, but
> * haven’t approved, and
> * is merged without notice,
> 
> can be confusing — who ensures my comments or concerns were resolved?
> 
> Again, I’m totally fine with the change itself — just asking for a bit of extra coordination. Thanks!

Got it. Apologies for hastily landing this @banach-space, I will make sure to make sure all comments are addressed and explicitly say so next time. 

https://github.com/llvm/llvm-project/pull/137651