[Mlir-commits] [mlir] [mlir][EmitC] Add pass that combines all available emitc conversions (PR #117549)

Thu May 1 09:17:24 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-arm64-windows-msvc` running on `linaro-armv8-windows-msvc-01` while building `mlir` at step 5 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/207/builds/903

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-unified-tree) failure: build (failure)
...
  359 |       return {APFloat(*smt, value.real()), APFloat(*smt, value.imag())};
      |              ^
c:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.37.32822\include\complex(1302,5): note: 'complex' has been explicitly marked deprecated here
 1302 |     _DEPRECATE_NONFLOATING_COMPLEX
      |     ^
c:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.37.32822\include\yvals_core.h(1408,7): note: expanded from macro '_DEPRECATE_NONFLOATING_COMPLEX'
 1408 |     [[deprecated("warning STL4037: "                                                   \
      |       ^
1 warning generated.
4554.605 [1228/10/5998] Building CXX object tools\mlir\lib\Conversion\ConvertToEmitC\CMakeFiles\obj.MLIRConvertToEmitC.dir\ConvertToEmitCPass.cpp.obj
FAILED: tools/mlir/lib/Conversion/ConvertToEmitC/CMakeFiles/obj.MLIRConvertToEmitC.dir/ConvertToEmitCPass.cpp.obj 
ccache C:\Users\tcwg\scoop\apps\llvm-arm64\current\bin\clang-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\build\tools\mlir\lib\Conversion\ConvertToEmitC -IC:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\mlir\lib\Conversion\ConvertToEmitC -IC:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\build\tools\mlir\include -IC:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\mlir\include -IC:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\build\include -IC:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported /Gw -Wundef -Werror=mismatched-tags -Werror=global-constructors /O2 /Ob2  -std:c++17 -MD  /EHs-c- /GR- -UNDEBUG /showIncludes /Fotools\mlir\lib\Conversion\ConvertToEmitC\CMakeFiles\obj.MLIRConvertToEmitC.dir\ConvertToEmitCPass.cpp.obj /Fdtools\mlir\lib\Conversion\ConvertToEmitC\CMakeFiles\obj.MLIRConvertToEmitC.dir\ -c -- C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\mlir\lib\Conversion\ConvertToEmitC\ConvertToEmitCPass.cpp
In file included from C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\mlir\lib\Conversion\ConvertToEmitC\ConvertToEmitCPass.cpp:9:
In file included from C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\mlir\include\mlir/Conversion/ConvertToEmitC/ConvertToEmitCPass.h:20:
C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\build\tools\mlir\include\mlir/Conversion/Passes.h.inc(4285,28): error: no member named 'string' in namespace 'std'
 4285 |   ::llvm::SmallVector<std::string> filterDialects;
      |                       ~~~~~^
In file included from C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\mlir\lib\Conversion\ConvertToEmitC\ConvertToEmitCPass.cpp:11:
In file included from C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\mlir\include\mlir/Conversion/ConvertToEmitC/ToEmitCInterface.h:14:
In file included from C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\mlir\include\mlir/IR/OpDefinition.h:22:
In file included from C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\mlir\include\mlir/IR/Dialect.h:17:
In file included from C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\mlir\include\mlir/IR/OperationSupport.h:19:
C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\mlir\include\mlir/IR/BuiltinAttributes.h(359,14): warning: 'complex' is deprecated: warning STL4037: The effect of instantiating the template std::complex for any type other than float, double, or long double is unspecified. You can define _SILENCE_NONFLOATING_COMPLEX_DEPRECATION_WARNING to suppress this warning. [-Wdeprecated-declarations]
  359 |       return {APFloat(*smt, value.real()), APFloat(*smt, value.imag())};
      |              ^
c:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.37.32822\include\complex(1302,5): note: 'complex' has been explicitly marked deprecated here
 1302 |     _DEPRECATE_NONFLOATING_COMPLEX
      |     ^
c:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.37.32822\include\yvals_core.h(1408,7): note: expanded from macro '_DEPRECATE_NONFLOATING_COMPLEX'
 1408 |     [[deprecated("warning STL4037: "                                                   \
      |       ^
1 warning and 1 error generated.
4555.256 [1228/9/5999] Building CXX object tools\mlir\lib\Conversion\ControlFlowToSCF\CMakeFiles\obj.MLIRControlFlowToSCF.dir\ControlFlowToSCF.cpp.obj
In file included from C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\mlir\lib\Conversion\ControlFlowToSCF\ControlFlowToSCF.cpp:13:
In file included from C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\mlir\include\mlir/Conversion/ControlFlowToSCF/ControlFlowToSCF.h:18:
In file included from C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\mlir\include\mlir/Transforms/CFGToSCF.h:18:
In file included from C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\mlir\include\mlir/IR/Builders.h:12:
In file included from C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\mlir\include\mlir/IR/OpDefinition.h:22:
In file included from C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\mlir\include\mlir/IR/Dialect.h:17:
In file included from C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\mlir\include\mlir/IR/OperationSupport.h:19:
C:\Users\tcwg\llvm-worker\flang-arm64-windows-msvc\llvm-project\mlir\include\mlir/IR/BuiltinAttributes.h(359,14): warning: 'complex' is deprecated: warning STL4037: The effect of instantiating the template std::complex for any type other than float, double, or long double is unspecified. You can define _SILENCE_NONFLOATING_COMPLEX_DEPRECATION_WARNING to suppress this warning. [-Wdeprecated-declarations]
  359 |       return {APFloat(*smt, value.real()), APFloat(*smt, value.imag())};
      |              ^
c:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.37.32822\include\complex(1302,5): note: 'complex' has been explicitly marked deprecated here
 1302 |     _DEPRECATE_NONFLOATING_COMPLEX
      |     ^
c:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.37.32822\include\yvals_core.h(1408,7): note: expanded from macro '_DEPRECATE_NONFLOATING_COMPLEX'
 1408 |     [[deprecated("warning STL4037: "                                                   \
      |       ^

```

</details>

https://github.com/llvm/llvm-project/pull/117549